Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong syntax #2861

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Fix wrong syntax #2861

merged 2 commits into from
Jul 11, 2022

Conversation

nakai-omer
Copy link
Contributor

Current syntax for target_include_directories is wrong, and causes the followin exception:
target_include_directories called with invalid arguments

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix required, then we can merge this.

source/The-ROS2-Project/Contributing/Migration-Guide.rst Outdated Show resolved Hide resolved
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor

Thanks, this looks good. I'm going to go ahead and merge it.

@clalancette clalancette merged commit 70b9aa6 into ros2:humble Jul 11, 2022
@clalancette
Copy link
Contributor

@Mergifyio backport foxy galactic rolling

mergify bot pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)
mergify bot pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)
mergify bot pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)
@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2022

backport foxy galactic rolling

✅ Backports have been created

clalancette pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)

Co-authored-by: nakai-robotics <108797279+nakai-robotics@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)

Co-authored-by: nakai-robotics <108797279+nakai-robotics@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Jul 11, 2022
* Fix wrong syntax

Current syntax for `target_include_directories` is wrong, and causes the followin exception:
`target_include_directories called with invalid arguments`

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 70b9aa6)

Co-authored-by: nakai-robotics <108797279+nakai-robotics@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants