Document tf2::TimePoint vs rclcpp::Time #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
requested changes
Oct 5, 2022
Comment on lines
50
to
51
| The ``tf2`` package has it's own time type ``tf2::TimePoint``. | ||
| This is different from ``rclcpp::Time``. |
There was a problem hiding this comment.
Suggested change
| The ``tf2`` package has it's own time type ``tf2::TimePoint``. | |
| This is different from ``rclcpp::Time``. | |
| The ``tf2`` package has its own time type ``tf2::TimePoint``, which is different from ``rclcpp::Time``. |
There was a problem hiding this comment.
Combined sentences and hopefully removed trailing whitespace in 3b3578c
clalancette
added
the
backport-all
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
approved these changes
Oct 5, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Document tf2::TimePoint vs rclcpp::Time Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 3d8b551)
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Document tf2::TimePoint vs rclcpp::Time Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 3d8b551)
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Document tf2::TimePoint vs rclcpp::Time Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 3d8b551)
clalancette
pushed a commit
that referenced
this pull request
Oct 5, 2022
clalancette
pushed a commit
that referenced
this pull request
Oct 5, 2022
clalancette
pushed a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/rviz#894
This documents that
tf2::TimePointis different fromrclcpp::Time, and explains whytf2::TimePointZerowas used.