Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release note about change to log file flushing #3193

Merged
merged 4 commits into from
Nov 18, 2022
Merged

release note about change to log file flushing #3193

merged 4 commits into from
Nov 18, 2022

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 17, 2022

@wjwwood wjwwood self-assigned this Nov 17, 2022
@wjwwood wjwwood mentioned this pull request Nov 17, 2022
Merged
ivanpauno
ivanpauno approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I only have one minor suggestion

source/Releases/Release-Iron-Irwini.rst Outdated Show resolved Hide resolved
clalancette
clalancette reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general, I've made one comment for something else we should add.

source/Releases/Release-Iron-Irwini.rst Outdated Show resolved Hide resolved
audrow
audrow approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a nitpick and comment about possibly moving some text. Barring those, it looks good so I'll approve.

source/Releases/Release-Iron-Irwini.rst Outdated Show resolved Hide resolved
source/Releases/Release-Iron-Irwini.rst Outdated Show resolved Hide resolved
source/Releases/Release-Iron-Irwini.rst Outdated Show resolved Hide resolved
wjwwood and others added 2 commits November 18, 2022 14:23
@wjwwood @ivanpauno @audrow
Apply suggestions from code review
c477688 
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
@wjwwood
emphasize note about experimental status
328c317 
also link to issue about logging config file plans
@wjwwood wjwwood merged commit 2002bbd into rolling Nov 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the wjwwood-patch-1 branch November 18, 2022 23:43
@mergify mergify bot mentioned this pull request Nov 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@wjwwood @mergify
release note about change to log file flushing (#3193)
ba38a8a 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@wjwwood @mergify
release note about change to log file flushing (#3193)
a6e9246 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)
This was referenced Nov 18, 2022
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@wjwwood @mergify
release note about change to log file flushing (#3193)
959f727 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)
clalancette pushed a commit that referenced this pull request Nov 21, 2022
@mergify @wjwwood
release note about change to log file flushing (#3193) (#3196)
8f3c91d 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)

Co-authored-by: William Woodall <william@osrfoundation.org>
clalancette pushed a commit that referenced this pull request Nov 21, 2022
@mergify @wjwwood
release note about change to log file flushing (#3193) (#3197)
4c4a3ad 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)

Co-authored-by: William Woodall <william@osrfoundation.org>
clalancette pushed a commit that referenced this pull request Nov 21, 2022
@mergify @wjwwood
release note about change to log file flushing (#3193) (#3198)
7763472 
* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)

Co-authored-by: William Woodall <william@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@ivanpauno ivanpauno ivanpauno approved these changes

@audrow audrow audrow approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjwwood @clalancette @audrow @ivanpauno