[rolling] Clarify usage of on_parameter_event #3237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mention usage of AsyncParametersClient * Add brief code example Signed-off-by: Ryan Friedman <ryan_friedman@trimble.com>
RFRIEDM-Trimble
force-pushed
the
clarify-use-of-on-parameter-event
branch
from
d6e01de to
0e5b4f2
Compare
|
I know that this has been open a long time. However, this part of the documentation has already been revamped corresponding to the new callbacks available in Iron and newer. I also think it is more explicit about the use of these callbacks now. Given all of that, I'm going to close this out. If you still feel that the current documentation is unclear, please feel free to open a new PR updating it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, the code example has not been tested yet, I would prefer to make a full example and link to it.