Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the Fedora build instructions into the RHEL ones. #3487

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

clalancette
Copy link
Contributor

The original Fedora installation page was written back in the mists of time, and haven't changed a whole lot since then. However, the tooling to enable development of ROS 2 on Fedora has changed considerably (thanks in no small part to the efforts of @cottsay).

In particular, developing on Fedora is 90% the same as developing on RHEL, with the only difference being that no additional repositories need to be enabled on Fedora. So merge together the Fedora and RHEL installation instructions. Note that we also redirect the old
Fedora links to the RHEL installation page.

The original Fedora installation page was written back in
the mists of time, and haven't changed a whole lot since
then.  However, the tooling to enable development of ROS 2
on Fedora *has* changed considerably (thanks in no small
part to the efforts of @cottsay).

In particular, developing on Fedora is 90% the same as
developing on RHEL, with the only difference being that
no additional repositories need to be enabled on Fedora.
So merge together the Fedora and RHEL installation
instructions.  Note that we also redirect the old
Fedora links to the RHEL installation page.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from cottsay April 28, 2023 04:34
@clalancette clalancette requested a review from audrow as a code owner April 28, 2023 04:34
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the instructions regarding the differences between RHEL, Rocky Linux, and AlmaLinux regarding crb/powertools naming, but we should do that in a separate PR.

Thanks for tackling this, Chris.

@clalancette clalancette added backport-humble backport at reviewers discretion; from rolling to humble backport-iron backport at reviewers discretion; from rolling to iron and removed backport-humble backport at reviewers discretion; from rolling to humble labels Apr 28, 2023
@clalancette clalancette merged commit 87835ae into rolling Apr 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-fedora branch April 28, 2023 18:03
mergify bot pushed a commit that referenced this pull request Apr 28, 2023
The original Fedora installation page was written back in
the mists of time, and haven't changed a whole lot since
then.  However, the tooling to enable development of ROS 2
on Fedora *has* changed considerably (thanks in no small
part to the efforts of @cottsay).

In particular, developing on Fedora is 90% the same as
developing on RHEL, with the only difference being that
no additional repositories need to be enabled on Fedora.
So merge together the Fedora and RHEL installation
instructions.  Note that we also redirect the old
Fedora links to the RHEL installation page.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 87835ae)
clalancette added a commit that referenced this pull request Apr 28, 2023
The original Fedora installation page was written back in
the mists of time, and haven't changed a whole lot since
then.  However, the tooling to enable development of ROS 2
on Fedora *has* changed considerably (thanks in no small
part to the efforts of @cottsay).

In particular, developing on Fedora is 90% the same as
developing on RHEL, with the only difference being that
no additional repositories need to be enabled on Fedora.
So merge together the Fedora and RHEL installation
instructions.  Note that we also redirect the old
Fedora links to the RHEL installation page.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 87835ae)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants