Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell users to 'apt update' before installing ros-dev-tools. #3491

Merged
merged 1 commit into from
May 3, 2023

Conversation

clalancette
Copy link
Contributor

If the users follow the instructions as-is right now, they will fail to apt update before trying to install ros-dev-tools, which will lead to failure. Update the instructions here for that.

If the users follow the instructions as-is right now, they
will fail to apt update before trying to install ros-dev-tools,
which will lead to failure.  Update the instructions here
for that.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette added the backport-iron backport at reviewers discretion; from rolling to iron label May 3, 2023
@clalancette clalancette requested a review from Yadunund May 3, 2023 13:40
@clalancette clalancette requested a review from audrow as a code owner May 3, 2023 13:40
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clalancette clalancette merged commit f4b9ed2 into rolling May 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/binary-apt-update branch May 3, 2023 13:45
mergify bot pushed a commit that referenced this pull request May 3, 2023
If the users follow the instructions as-is right now, they
will fail to apt update before trying to install ros-dev-tools,
which will lead to failure.  Update the instructions here
for that.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit f4b9ed2)
clalancette added a commit that referenced this pull request May 3, 2023
…3492)

If the users follow the instructions as-is right now, they
will fail to apt update before trying to install ros-dev-tools,
which will lead to failure.  Update the instructions here
for that.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit f4b9ed2)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants