Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using-python-packages note issue #3565

Merged
merged 2 commits into from
May 9, 2023
Merged

Fix using-python-packages note issue #3565

merged 2 commits into from
May 9, 2023

Conversation

avanmalleghem
Copy link
Contributor

Please refer to osrf/ros2_test_cases#1020

Yadunund
Yadunund approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clalancette
clalancette requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One more small update, then this will be good to merge.

source/How-To-Guides/Using-Python-Packages.rst Outdated Show resolved Hide resolved
@avanmalleghem @clalancette
Update source/How-To-Guides/Using-Python-Packages.rst
e4ed259 
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
clalancette approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating, this looks good now.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label May 9, 2023
@clalancette clalancette merged commit 882713f into ros2:rolling May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
@avanmalleghem @mergify
Fix using-python-packages note issue (#3565)
5c56bd4 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)
mergify bot pushed a commit that referenced this pull request May 9, 2023
@avanmalleghem @mergify
Fix using-python-packages note issue (#3565)
a7fd014 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)
This was referenced May 9, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 9, 2023
@avanmalleghem @mergify
Fix using-python-packages note issue (#3565)
9c3b362 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)
@mergify mergify bot mentioned this pull request May 9, 2023
Merged
clalancette pushed a commit that referenced this pull request May 9, 2023
@mergify @avanmalleghem
Fix using-python-packages note issue (#3565) (#3570)
545f438 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)

Co-authored-by: Antoine Van Malleghem <a.vanmalleghem@gmail.com>
clalancette pushed a commit that referenced this pull request May 9, 2023
@mergify @avanmalleghem
Fix using-python-packages note issue (#3565) (#3571)
fabfe41 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)

Co-authored-by: Antoine Van Malleghem <a.vanmalleghem@gmail.com>
clalancette pushed a commit that referenced this pull request May 9, 2023
@mergify @avanmalleghem
Fix using-python-packages note issue (#3565) (#3572)
545d4b2 
* Fix using-python-packages note issue

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 882713f)

Co-authored-by: Antoine Van Malleghem <a.vanmalleghem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avanmalleghem @clalancette @Yadunund