Rewrite simple python client explanation. #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
fujitatomoya
approved these changes
Nov 1, 2023
clalancette
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 53921ee)
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 53921ee)
clalancette
added a commit
that referenced
this pull request
Nov 2, 2023
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 53921ee) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Nov 2, 2023
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 53921ee) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it look much more like the service section, with more explanation. It also gets rid of an inconsistency where it was referencing a while loop that is no longer there.
This should fix #3997