Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IDE notes for VSCode #4036

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Added IDE notes for VSCode #4036

merged 2 commits into from
Nov 28, 2023

Conversation

RobertoRoos
Copy link
Contributor

Following #4022

VSCode is actually very easy!

clalancette
clalancette requested changes Nov 28, 2023
View reviewed changes
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
@RobertoRoos
Copy link
Contributor Author

Thanks @clalancette for the lighting fast review

clalancette
clalancette approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the improvements.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Nov 28, 2023
@clalancette clalancette merged commit d9c53f0 into ros2:rolling Nov 28, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
@RobertoRoos @mergify
Added IDE notes for VSCode (#4036)
0e30244 
* Added notes for VSCode

(cherry picked from commit d9c53f0)
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
@RobertoRoos @mergify
Added IDE notes for VSCode (#4036)
c591afd 
* Added notes for VSCode

(cherry picked from commit d9c53f0)
This was referenced Nov 28, 2023
Merged
Merged
clalancette pushed a commit that referenced this pull request Nov 28, 2023
@mergify @RobertoRoos
Added IDE notes for VSCode (#4036) (#4038)
fce646e 
* Added notes for VSCode

(cherry picked from commit d9c53f0)

Co-authored-by: Robert <robert.soor@gmail.com>
clalancette pushed a commit that referenced this pull request Nov 28, 2023
@mergify @RobertoRoos
Added IDE notes for VSCode (#4036) (#4039)
66840a1 
* Added notes for VSCode

(cherry picked from commit d9c53f0)

Co-authored-by: Robert <robert.soor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertoRoos @clalancette @Robert-DEMCON