Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'ros2 param list' stuck when node create with namespace #128

Closed
realdream opened this issue Jul 31, 2018 · 2 comments · Fixed by #146
Closed

'ros2 param list' stuck when node create with namespace #128

realdream opened this issue Jul 31, 2018 · 2 comments · Fixed by #146
Assignees
Labels
bug Something isn't working

Comments

@realdream
Copy link

realdream commented Jul 31, 2018

Bug report

Required Info:

  • Operating System:
    • Ubuntu 16.04
  • Installation type:
    • from source
  • Version or commit hash:
    • release bouncy
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

ros2 run demo_nodes_cpp talker __ns:=/demo
ros2 param list

Actual behavior

the 'ros2 param list' stuck forever with out output any message
'ros2 param set/get' also failed


edit by @sloretz for waffle.io
blocked by #105

@sloretz sloretz added the bug Something isn't working label Aug 1, 2018
@sloretz
Copy link
Contributor

sloretz commented Aug 1, 2018

Thanks for the bug report @realdream . I can reproduce ros2 param list being stuck forever and being unable to get/set parameters using bouncy patch release 1 installed from debs.

Output when trying to get or set a parameter on a node with a namespace set.

developer@bbd2c434522d:~$ ros2 param set talker foo true
Wait for service timed out
developer@bbd2c434522d:~$ ros2 param get talker foo
Wait for service timed out
developer@bbd2c434522d:~$ ros2 param get /demo/talker foo
Node not found
developer@bbd2c434522d:~$ ros2 param set /demo/talker foo true
Node not found

Services and topics

developer@bbd2c434522d:~$ ros2 service list
/demo/talker/describe_parameters
/demo/talker/get_parameter_types
/demo/talker/get_parameters
/demo/talker/list_parameters
/demo/talker/set_parameters
/demo/talker/set_parameters_atomically
developer@bbd2c434522d:~$ ros2 topic list
/clock
/demo/chatter
/demo/parameter_events

Possibly related to #105 ? list gets all node names from ros2node's api

node_names = get_node_names(
node=node, include_hidden_nodes=args.include_hidden_nodes)

Then it creates a client with the node name assuming it will be a single token.

client = node.create_client(
ListParameters,
'/{node_name}/list_parameters'.format_map(locals()))

@mjcarroll mjcarroll added the ready Work is about to start (Kanban column) label Aug 16, 2018
@mjcarroll
Copy link
Member

I agree with your assessment @sloretz. This is going to be dependent on the rmw returning a list of namespaced names, in addition to just the node names.

@mjcarroll mjcarroll added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed ready Work is about to start (Kanban column) in progress Actively being worked on (Kanban column) labels Aug 29, 2018
@dirk-thomas dirk-thomas self-assigned this Sep 6, 2018
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Sep 6, 2018
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
…ns (ros2#128)

* add actions for pusing and popping launch configs

Signed-off-by: William Woodall <william@osrfoundation.org>

* add tests for push and pop launch configs actions

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix doc copy-paste error

Signed-off-by: William Woodall <william@osrfoundation.org>

* another doc fixup

Signed-off-by: William Woodall <william@osrfoundation.org>
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants