[ros2node] Make ros2 node list list namespaces as well as names
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
added
in review
dirk-thomas
reviewed
Aug 29, 2018
| @@ -56,6 +56,8 @@ def main(*, script_name='_ros2_daemon', argv=None): | |||
| # expose getter functions of node | |||
| server.register_function( | |||
| _print_invoked_function_name(node.get_node_names)) | |||
There was a problem hiding this comment.
Should this function be removed since it only provides incomplete information?
There was a problem hiding this comment.
It is currently still being used by ros2lifecycle. We haven't had a bug issued against that, but I'll take this as an opportunity to update that as well.
There was a problem hiding this comment.
That is, I'll remove it in the PR that updates ros2lifecycle.
|
Superseded by #146. |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Add tests for ensure_argument_type() function
* Add tests for normalize_to_list_of_substitutions() function
* Add tests for perform_substitutions() function
* Add tests for signal_management module
* Left TODOs for functional tests.
* Add test for create_future() function
* Add tests for visit_all_entities_and_collect_futures() function
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
This also adds explicit tests for the warnings produced from using deprecated parameters. Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
To test:
Expected output: