add ros2 multicast commands #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
mjcarroll
approved these changes
Aug 30, 2018
|
@mjcarroll Thanks for the review. In order to be mergable the referenced PR needs to be reviewed and merged though. |
|
As it turned out Windows didn't like the multicast group Along the way I made sure that the sockets are always closed, the multicast membership is dropped and the sender address is shown on the receiving side. I tried it successfully between one of the Windows nodes and my machine 🎉
|
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Add LaunchLogger class Supports logging messages from multiple processes and modules to the screen, a common log file, or both. LaunchLogger is a singleton and when it is first instantiated a log file is created of the form 'DATETIME-launch-HOSTNAME-PID.log'. Messages sent to the screen or the log file will have the format 'TIME [LEVEL] NAME: MESSAGE'. * Add different formats for log and screen in launch logger The timestamp in the screen format is optional. * Use LoggerLevel.INFO instead of logging.INFO * Fixup 'screen' logging logic Also extends LaunchLogger interface. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Refactors launch logging. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Preconfigures launch.logging loggers. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Addresses peer review comments. - Fix style and documentation issues. - Removes dangling TODO. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * style and documentation fixups Signed-off-by: William Woodall <william@osrfoundation.org> * fix name shadowing (mypy complained) Signed-off-by: William Woodall <william@osrfoundation.org> * Replace capfd with capsys in launch.logging tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Integrate LaunchLogger in launch Replacing usage of the Python logging module with the new LaunchLogger. * Integrate LaunchLogger in launch_ros Also, removed unecessary logging logic. * Clean up LaunchLogger integration with launch Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Refactor launch logging integration. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Switch to non-relative launch.logging imports. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Turn ExecuteProcess output_prefix into an output_format. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Convert launch logging API names to snake case. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Minor fixes after rebase. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Fix test_node_frontend Fix ros2#145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io> * Some renamings and perform the same fixes on test_push_ros_namespace_frontend Signed-off-by: Dan Rose <dan@digilabs.io> * Remove incorrect docstring Signed-off-by: Dan Rose <dan@digilabs.io> * Add copyright for files with contributions Signed-off-by: Dan Rose <dan@digilabs.io> * Fix formatting Signed-off-by: Dan Rose <dan@digilabs.io> * Fix copyrights Signed-off-by: Dan Rose <dan@digilabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
multicastcommand contains two verbs:receivewaiting for a single UDP multicast packetsendsending a single UDP multicast packetThe tool can be used to check if multicast UDP packets are passed between two endpoints.
This package uses a
setup.cfgfile and therefore requires colcon/colcon-ros#38 (only when using--symlink-install).