Generate LICENSE files on ros2 pkg create. #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if the '--license' command-line argument is one of the ones that ament_copyright knows, fetch the license text out of ament_copyright and place it in 'LICENSE' at the root of the package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Supporting the SPDX identifier seems a little more friendly to me, since that might be what some users want to appear in the package.xml. |
|
I agree about the SPDX stuff. I've already seen two packages use that in their package.xml files during my ros/rosdistro cycle. |
|
+1 for SPDX support it will make our lives much simpler in the future for auditing |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
All right, I've switched this over to using SPDX identifiers instead. This PR now requires ament/ament_lint#315 to go in first. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wjwwood
approved these changes
Jun 18, 2021
|
@ros-pull-request-builder retest this please |
|
CI:
|
|
All right, approved, CI is green. Going to merge, thanks everyone! |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if the '--license' command-line argument is one of
the ones that ament_copyright knows, fetch the license text
out of ament_copyright and place it in 'LICENSE' at the
root of the package.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Here's the current list of strings that will trigger the creation of the LICENSE file:
One thing to be aware of here is that this is the first use of
ament_copyrightin anexec_depend. I don't think that should be a problem, but it is something to think about.An enhancement we could do here is to add the SPDX identifiers to the license tuple in ament_copyright, and then use that instead. I don't mind strongly which way we go, but we should think about it and be deliberate; changing it later on will be difficult. Feedback is most welcome.
@nuclearsandwich @tfoote @gbalke @ros2/team FYI.