Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO for OpenSplice DDS issue. #928

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove TODO for OpenSplice DDS issue. #928

merged 1 commit into from
Sep 4, 2024

Conversation

fujitatomoya
Copy link
Collaborator

minor cosmetic fix to remove TODO for https://github.com/ros2/rmw_opensplice

@fujitatomoya
Remove TODO for OpenSplice DDS issue.
5746da4 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Sep 3, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ros2/rmw_opensplice is archived 3 years ago, i do not think we want to keep this...

Comment removal only, does not require CI.

clalancette
clalancette approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, assuming that either we have green CI or the Rpr job is green.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #928
Gist: https://gist.githubusercontent.com/fujitatomoya/7c1c52e48fd3c1eb9e19fd1408082e3a/raw/8c0051f737a147fc31d86232d620cceaff4f1a7b/ros2.repos
BUILD args: --packages-up-to ros2topic
TEST args: --packages-select ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14504

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit ddd6146 into rolling Sep 4, 2024
2 of 3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/remove-opensplice-todo branch September 4, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow

@gbiggs gbiggs Awaiting requested review from gbiggs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @clalancette @ahcorde