Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple topics via ros2 topic hz. #929

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Sep 4, 2024

replaces #831 and closes #830

Note: after the merge, we need to update the documentation

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@TannerGilbert
Copy link

Thanks for the quick reply on the other PR. I have one more question. Will changes like these only be merged into rolling or will there also be backports to older still supported versions like Humble?

@fujitatomoya
Copy link
Collaborator Author

@TannerGilbert

basically we enforce API compatibility for released distribution, see more details for https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html#versioning. and this PR breaks API combability including behavior change, so we would not backport the fix to released distributions.

If we want to backport, what i would suggest is that,

  1. merge this fix into rolling 1st, then wait for a couple of weeks as soak time to make sure nothing happens in the main.
  2. and then, consider backport fix with API compatibility to jazzy, iron and humble. (each distro could have base code difference)

CC: @clalancette

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@ahcorde @clalancette @sloretz i would like to request the review.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #929
Gist: https://gist.githubusercontent.com/fujitatomoya/d0adaeee62fd2694795a2797a396d313/raw/ec0acd6ad03b9941f5b0c3ccf1b5ce71e24577dc/ros2.repos
BUILD args: --packages-above-and-dependencies ros2topic
TEST args: --packages-above ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14521

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e2fddb2 into rolling Sep 6, 2024
2 of 3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/topic-hz-multiple-topics branch September 6, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants