-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ros_testing metapackage and ros2test CLI package #1
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Running CI (running up to several system_tests and demo package to save time, using ros2/ros2#704 for a ros2.repos file): Previous runs with known/unrelated failures: |
What did we decide I should rename this repository to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ros2test/package.xml
Outdated
schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
<package format="2"> | ||
<name>ros2test</name> | ||
<version>0.8.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for starting at this version? I don't think it matters where you start, but I was just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just matching the version of most of the other launch
packages. Any other way you'd rather go about it? I don't have a strong preference and I can't tell if we have a stricter policy on this regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both are in separate repositories they will level independently. So there is no reason to align them now. Please start this repo with version 0.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
I think we didn't really decide. I'm fine with either, though I used |
How about naming this repo |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Tests seem unrelated though no less worrisome :/ |
Closes ros2/launch#208. This pull request adds:
ros_testing
, theament_cmake
entrypoint package to launch testing in ROS2, bringing all necessary dependencies and providing a convenience CMake macro,add_ros_test()
to register ROS2 launch tests.ros2test
, theros2
CLI extension package that provides atest
command for ROS2 launch tests.