-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Regex topic selection or rejection #971
Comments
@andrewbest-tri We already have special parameter for excluding topics.
I think it should cover your case. |
So indeed it appears this is available in galactic. We're on foxy but have requisitioned a backport. I will investigate if there are issues using the existing filters. In the future, any advice for how I could find out about these available features before filing issues? Is this documented and I missed it? |
Unfortunately, I'd say that documentation is the most lacking part of the project right now. Significant feature backports can be difficult, while maintaining the required API compatibility, especially if the feature was introduced much later after the code had changed a lot. |
@emersonknapp @MichaelOrlov I am closing this for now. There are already issues related to documentation. #1412 |
Description
Deciding which topics to bag could be improved by allowing a regex for topic subscription and rejection. In this way, we could prefix topics we definitely do not want to log, e.g.
ros bag record --exlucude /nolog/*
, or subscribe to entire device feeds without struggling to capture all possible topics, e.g.ros bag record /imu/*
This would enable us to expose additional topics from devices and experiment processes without having to modify the bagger constantly.
Related Issues
Relates to #970 , the mix of period discovery and regex rejection would be a powerful combination of features.
Completion Criteria
Implementation Notes / Suggestions
Testing Notes / Suggestions
The text was updated successfully, but these errors were encountered: