Splitted rosidl_generator_c and rosidl_generator_cpp in two: rosidl_generator_x and rosidl_runtime_x

[ahcorde]

As discussed in the issue ros2/ros2#442 I have spplited in to rosidl_generator_cand rosidl_generator_cpp.

I don't really know if rosidl_runtime_cpp is needed. because this package is not creating any runtime dependency such as a .so/dylib/dll. But I have seen this comment https://github.com/ros2/rosidl/blob/master/rosidl_generator_cpp/include/rosidl_generator_cpp/message_initialization.hpp#L18 from @clalancette and I dediced to splitt it too, also because I think it makes sense for consistency.

[dirk-thomas]

Commonly a package only provides headers with a namespace / directory matching the package name. Should we consider updating the namespace / directory of the moved headers? If yes, how much code would be affected by this breaking change?

[ahcorde]

I was trying to do so, but this will require a lot of changes in many packages. I was trying to reduce the amount of noise regarding this change.

Also the resources are in the generator but the headers are in the runtime. This will require also some changes in the resources.

but if this is the way I can put some time on it

[dirk-thomas]

We can land the PR as is. I was mostly wondering if it makes sense / if we want to follow up on the naming afterwards.

[ahcorde]

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

[ahcorde]

Removed rosidl_generator_c and rosidl_generator_cpp from rosidl_typesupport_introspection_c and rosidl_typesupport_introspection_cpp because these packages are not generators and they are not making use of the CMakeLists macros

[rotu]

This breaks binary compatibility in its public API. Shouldn't it bump the major version number?

[wjwwood]

This breaks binary compatibility in its public API. Shouldn't it bump the major version number?

We will, I assume, when we next release from master.

[dirk-thomas]

This breaks binary compatibility in its public API. Shouldn't it bump the major version number?

Since the packages in this repo have 0.x versions there is no need to bump the major version. Anything can change anytime in pre 1.x versions.

Independent of this change the goal is to bring several repos / packages to at least version 1.0 for the Foxy release.

[ahcorde]

• Updated all repos involved in this change.
• Skipping ros1_bridge, qt_*, rqt_*, and rviz_* packages.
• Testing against test_rclcpp and rosbag2_tests.

• Linux
• Linux-aarch64
• macOS
• Windows

• One warning made the builds unstable but there is a (PR pending)

CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

• projectroot.cppcheck

Windows

• some failures in test_rclcpp