Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to rosidl_generator_type_description #840

Open
wants to merge 8 commits into
base: rolling
Choose a base branch
from
Open

Add types to rosidl_generator_type_description #840

wants to merge 8 commits into from

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
Add types to rosidl_generator_type_description
7415db7 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix some types
444e994 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
flake8
0941985 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
address indexing type errors
83f6eab 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
add str cast
ef90617 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix field_type_capacity
486b95a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Dec 6, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2024

update

✅ Branch has been successfully updated

@sloretz
Copy link
Contributor

sloretz commented Dec 6, 2024

Pulls: #840
Gist: https://gist.githubusercontent.com/sloretz/bf62523da89b9771d5003277d97ee692/raw/c529bf3fe304c49d309abcaf327f7ea50f1637e8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_tests rosidl_generator_type_description
TEST args: --packages-above rosidl_generator_tests rosidl_generator_type_description
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14912

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor Author

@sloretz can the CI be re-run since the windows bug has been fixed?

@sloretz
Copy link
Contributor

sloretz commented Dec 10, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@sloretz
Copy link
Contributor

sloretz commented Dec 13, 2024

Pulls: #840
Gist: https://gist.githubusercontent.com/sloretz/05aa8bfba79337af4b85c39a4e1b0e78/raw/c529bf3fe304c49d309abcaf327f7ea50f1637e8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_tests rosidl_generator_type_description
TEST args: --packages-above rosidl_generator_tests rosidl_generator_type_description
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14957

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Dict over dict
6a6ad9a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Dec 14, 2024 •
edited
Loading

Pulls: #840
Gist: https://gist.githubusercontent.com/sloretz/13781260df9fccdc88ea2c6d6203814d/raw/c529bf3fe304c49d309abcaf327f7ea50f1637e8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_tests rosidl_generator_type_description
TEST args: --packages-above rosidl_generator_tests rosidl_generator_type_description
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14958

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status Edit: Infra issue, rerun: Build Status

@InvincibleRMC
Copy link
Contributor Author

@sloretz is this good to merge in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@methylDragon methylDragon Awaiting requested review from methylDragon

@quarkytale quarkytale Awaiting requested review from quarkytale

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InvincibleRMC @sloretz