Skip to content

Provide base classes in rosidl_pycommon #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 18, 2025
Merged

Provide base classes in rosidl_pycommon #887

merged 6 commits into from
Sep 18, 2025

Conversation

@InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Aug 27, 2025

Description

See ros2/rosidl_python#230

The original issue ros2/rosidl_python#215 recommended placing the base classes in rosidl_pycommon and that seemed reasonable to me.

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

@InvincibleRMC
Add base classes
316eea5 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC mentioned this pull request Aug 27, 2025
Merged
@InvincibleRMC
Fix lint
857e65e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
switch file name to interface_** from message_**
cb7f783 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add complementing base classes
83e0795 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@christophebedard christophebedard self-assigned this Sep 11, 2025
@InvincibleRMC
lint
9a9127d 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@christophebedard
Copy link
Member

christophebedard commented Sep 11, 2025

Pulls: ros2/rosidl_python#230, #887
Gist: https://gist.githubusercontent.com/christophebedard/eed622fd1da65170263b1734edfe11de/raw/b75cc11d0a0989e0916903b5dc6e8064be274b42/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_pycommon rosidl_generator_py
TEST args: --packages-above rosidl_pycommon rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16931

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Add empty slots to prevent changing message
b1fd630 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@christophebedard
Copy link
Member

christophebedard commented Sep 17, 2025 •
edited
Loading

Pulls: ros2/rosidl_python#230, #887
Gist: https://gist.githubusercontent.com/christophebedard/e44c47ef2dc14944e3f6dc0a1ce87cea/raw/1bd32654fcd99a86f61159ce9523b75466bf24c8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_pycommon rosidl_generator_py
TEST args: --packages-above rosidl_pycommon rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor Author

InvincibleRMC commented Sep 18, 2025

@christophebedard The CI looks promising. I think aarch CI crashed.

@christophebedard
Copy link
Member

christophebedard commented Sep 18, 2025

I found the job that was automatically triggered after the failure. Looks good, merging!

@christophebedard christophebedard merged commit 4edcac1 into ros2:rolling Sep 18, 2025
3 checks passed
@InvincibleRMC InvincibleRMC mentioned this pull request Oct 7, 2025
Merged
@sea-bass sea-bass mentioned this pull request Nov 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@christophebedard christophebedard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InvincibleRMC @christophebedard @fujitatomoya