Remove type_support_dispatch.cpp files. #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't actually add any code, since they only #include a header file with a templated function in them. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
Full CI, just to make sure there isn't some side effect I don't understand:
|
Contributor
Author
|
The test failures for all of the yellow builds are all in the nightlies (and most of them are already fixed). So this is ready for review. |
ivanpauno
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't actually add any code, since they only #include
a header file with a templated function in them.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
I think what happened here is that these files used to contain the implementation of
find_library_path,get_env_var, etc. PR #47 moved that functionality out of these files and into the rcpputils package, but didn't remove the (now empty) .cpp files. This PR just finishes cleaning them up.