Fix how header template works to prevent double-inclusion #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug introduced in #116 Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
|
adityapande-1995
approved these changes
Apr 9, 2024
ahcorde
approved these changes
Apr 9, 2024
I think we need to change this line to |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
delete-merged-branch
bot
deleted the
mjcarroll/fix_double_included_header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #116
This specifically generated cpplint warnings on generated services (for example https://ci.ros2.org/job/ci_linux/20791/#showFailuresLink)