Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service introspection #92

Merged
merged 9 commits into from
Feb 2, 2023
Merged

Service introspection #92

merged 9 commits into from
Feb 2, 2023

Conversation

ihasdapie
Copy link
Member

This PR is part of a prototype implementation for ros-infrastructure/rep#360 ros2/ros2#1285. It implements the new methods defined in rosidl_runtime_cpp in ros2/rosidl#700 allowing for rcl to populate service_event message payloads.

@ihasdapie ihasdapie mentioned this pull request Aug 10, 2022
Closed
14 tasks
@jacobperron jacobperron self-assigned this Sep 1, 2022
@jacobperron
Copy link
Member

rebased on rolling

ivanpauno
ivanpauno reviewed Nov 11, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check the rosidl_typesupport_fastrtps_c implementation, otherwise I think this is fine

rosidl_typesupport_fastrtps_c/resource/srv__type_support_c.cpp.em Outdated Show resolved Hide resolved
rosidl_typesupport_fastrtps_c/resource/srv__type_support_c.cpp.em Outdated Show resolved Hide resolved
@ivanpauno ivanpauno requested a review from wjwwood November 16, 2022 14:09
@ivanpauno ivanpauno requested a review from sloretz as a code owner November 17, 2022 18:16
@ivanpauno ivanpauno mentioned this pull request Dec 15, 2022
Merged
ihasdapie and others added 9 commits January 12, 2023 14:54
@ihasdapie @clalancette
add service introspection typesupport impls
1962674 
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
@ihasdapie @clalancette
use suffixes from rosidl_parser.definition
de5013d 
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
@ihasdapie @clalancette
use const void* for service_introspection_message__create handle fns
9c06dca 
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
@jacobperron @clalancette
Lint
3b0b662 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@ivanpauno @clalancette
Use create/destroy event function generated in rosidl_generator_c
1300649 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno @clalancette
Use common service event create/destroy function in cpp
a7dcad2 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno @clalancette
fixes
51d7f5c 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno @clalancette
please linters
ceb8f55 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno @clalancette
fix bug
e1eb8c5 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@clalancette clalancette force-pushed the service_introspection branch from 25c762b to e1eb8c5 Compare January 25, 2023 18:29
@clalancette
Copy link
Contributor

CI for this is in ros2/ros2#1285 (comment)

@clalancette clalancette merged commit fe7562c into rolling Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the service_introspection branch February 2, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@wjwwood wjwwood wjwwood approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ihasdapie @jacobperron @clalancette @wjwwood @mjcarroll @ivanpauno