This repository has been archived by the owner on Dec 9, 2021. It is now read-only.
remove assert on missing comment #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The DCO check failed. Please update your commit to contain a Also a reference to ADLINK-IST/opensplice#92 would have been helpful to understand the context of this change. |
|
@MarcelJordense Please update the commit to pass the DCO - otherwise we unfortunately can't accept the patch. |
Signed-off-by: Marcel Jordense <marcel.jordense@adlinktech.com>
|
@dirk-thomas I have added the Signed-off-by. |
|
CI is looking good:
|
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Jul 29, 2019
Signed-off-by: Marcel Jordense <marcel.jordense@adlinktech.com>
dirk-thomas
pushed a commit
that referenced
this pull request
Jul 29, 2019
Signed-off-by: Marcel Jordense <marcel.jordense@adlinktech.com>
This was referenced Jul 29, 2019
dirk-thomas
pushed a commit
that referenced
this pull request
Jul 29, 2019
Signed-off-by: Marcel Jordense <marcel.jordense@adlinktech.com> Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
pushed a commit
that referenced
this pull request
Jul 29, 2019
Signed-off-by: Marcel Jordense <marcel.jordense@adlinktech.com> Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
added a commit
that referenced
this pull request
Jul 30, 2019
dirk-thomas
added a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the OpenSplice idlpp pre-processor may no longer generate the // Generated comment in the generated files. Therefor this is assert is no valid.