Glsl override for nouveau #681
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
|
Looks like the The question rises, are nvidia drivers working as they intended to (GL 4.6 with GLSL>=150) and the other drivers are somewhat misleading (GL 4.6 but without GLSL>=150) - or - nvidia do what it shouldn't be able to and other drivers are actually working correctly? I'm still looking into it. |
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
|
Since this is still being looked into, I'm actually going to convert it to a draft. Feel free to convert back when it is ready. |
jacobperron
reviewed
Oct 29, 2021
|
|
||
| #ifdef __linux__ | ||
| // TODO(pijaro): Nouveanu and Intel drivers don't support glsl150 even if they "should". | ||
| // We fix version to 120 since this is the one we are currently using in materials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with Nouveau drivers with glsl150 shaders (introduced in PR #668).
It looks like Nouveau can't use GLSL 1.50 programs, even if the driver reports that it supports even newer version of GLSL.
Proposed piece of code is a workaround for Nouveau driver users in linux. It sets the rviz glsl version to 1.20 which works fine (but is slower than 1.50).