-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python bindings based on Pyside2 #889
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Christoph Hellmann Santos <christoph.hellmann.santos@ipa.fraunhofer.de>
This PR should wait for the conclusion of ros-visualization/python_qt_binding#114 before proceeding. But I just wanted to make one point:
Unfortunately, Windows support must get completed before we can consider merging this PR. Windows is one of our Tier-1 platforms, and so features that go in must also support it. Hopefully when we resolve the issue above this will become easier. |
Okay. Problem is, I am not really equipped to test this on Windows, as I am not to familiar with ROS2 on Windows. It would cost me a serious amount of time to do that. Generally, it would only be a thing of getting the correct paths for shiboken and pyside Libs and Execs into CMake - I think I can manage that. There is a python script for Pyside by Qt that is thought for Windoof and Linux to extract the necessary info and an example CMakeLists.txt. But testing this on Windows and managing the dependencies plus doing potential changes is something I cannot do right now. I see 2 options:
|
@clalancette Windows Dependencies: People will need to install pyside2 shiboken2 and shiboken2-generator from qt's release repository using pip. Instructions in readme. They will also need to add the installed dlls to PATH. If not we'll need to copy them to CMAKE_INSTALL_PREFIX/lib in a deployment step - this is kinda shady. Any opinions here?
Does anyone have a windows setup to test this? It is really hard to set this up in my company due to IT restrictions... |
This depends on ros/rosdistro#34243. Once merged checks should pass. |
This PR will add python bindings for rviz using Pyside2 for a couple of classes. The goal is to make rviz usable as a qwidget in python.
Some design decisions:
Open points: