Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable cross-vendor tests on Windows #476

Open
jacobperron opened this issue May 26, 2021 · 1 comment
Open

Re-enable cross-vendor tests on Windows #476

jacobperron opened this issue May 26, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

There is a TODO regarding disabled cross-vendor tests on Windows:

system_tests/test_communication/CMakeLists.txt

Line 160 in f460b6e

# TODO(wjwwood): Connext and Fast-RTPS do not currently communicate over pub/sub

It would be nice to resolve these and have the tests re-enabled again. I'm not sure what's required to make these tests pass.

Here's an older related PR: #323
And an old issue that has been resolved: ros2/rmw_fastrtps#246
@jacobperron jacobperron added the bug Something isn't working label May 26, 2021
@jacobperron jacobperron mentioned this issue May 26, 2021
Closed
@jacobperron
Copy link
Member Author

I've push a change re-enabling the tests (afa5184) and triggered a Windows build to see where we stand: Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobperron