Re-enable cross-vendor tests for Fast-RTPS on Windows. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the skip logic to allow tests to run.
|
@nuclearsandwich I faced the same cross-vendor issues in #328 and also had to skip some tests. This PR may no longer reflect all tests that have to be re-enabled. |
nuclearsandwich
added
ready
|
I'm guessing this PR is outdated, so I'm taking the liberty of closing it. I've created a ticket to capture re-enabling the cross vendor tests (#476). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the skip logic to allow tests to run.
This branch can be used to enable cross-vendor communications tests on Windows for investigating the issues further.
connects to ros2/rmw_fastrtps#246