Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longer timeout for tests with two clients #259

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Longer timeout for tests with two clients #259

merged 1 commit into from
Mar 9, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Mar 8, 2018

Fixes #212

Linux CI with ament_test_args: --only test_rclcpp --retest-until-fail 150 --ctest-args -R client_scope: Build Status

@dhood dhood added the in review Waiting for review (Kanban column) label Mar 8, 2018
@dhood dhood self-assigned this Mar 8, 2018
@dhood dhood changed the title Longer timeout for tests with two service servers Longer timeout for tests with two clients Mar 8, 2018
wjwwood
wjwwood approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sucks that we have to keep increasing these, but I guess it's better than flaky tests.

@dhood dhood merged commit c2ff66a into master Mar 9, 2018
@dhood dhood deleted the double_client_timeout branch March 9, 2018 18:16
@dhood dhood removed the in review Waiting for review (Kanban column) label Mar 9, 2018
@dhood dhood mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhood @wjwwood