Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle launch_testing assertExitCodes correctly #367

Merged
merged 2 commits into from
May 15, 2019

Conversation

ivanpauno
Copy link
Member

Follow-up of #340.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 15, 2019
@ivanpauno ivanpauno requested a review from hidmic May 15, 2019 13:29
@ivanpauno ivanpauno self-assigned this May 15, 2019
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@ivanpauno
Copy link
Member Author

new CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 8923ddf into master May 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/assert-exit-code-usage branch May 15, 2019 20:17
@ivanpauno ivanpauno removed the in review Waiting for review (Kanban column) label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants