Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for nested messages. #530

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

clalancette
Copy link
Contributor

This is an integration test to ensure that ros2/rmw_fastrtps#715 doesn't happen again.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@methylDragon
Copy link
Contributor

methylDragon commented Oct 3, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

(Oops, the system_tests package doesn't exist. We want test_communication instead.)

Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 pending green CI

@methylDragon
Copy link
Contributor

I think the gh actions CI is failing because the fix PR isn't in yet. Do we wait for the fix PR to go in before merging this?

@clalancette
Copy link
Contributor Author

I think the gh actions CI is failing because the fix PR isn't in yet. Do we wait for the fix PR to go in before merging this?

No, we don't need to do that. The CI in ros2/rosidl_typesupport_fastrtps#108 (comment) should be good enough for now. Once we merge this group of PRs in, I'll do a series of releases so that the Rpr jobs start working for all of them.

@clalancette clalancette merged commit c9569c1 into rolling Oct 4, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/nested-msg-integration-test branch October 4, 2023 12:24
@fujitatomoya
Copy link
Contributor

@Mergifyio backport iron humble

Copy link

mergify bot commented Nov 8, 2023

backport iron humble

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@fujitatomoya
Copy link
Contributor

@clalancette since i do not have write permission on this repo, can you do me a favor?

@clalancette
Copy link
Contributor Author

@Mergifyio backport iron humble

To be honest, I don't think we need to do this backport. We have the test in rolling, which I think is good enough. The fixes we should definitely backport.

@fujitatomoya
Copy link
Contributor

@clalancette sounds good to me. just thought all related PRs can be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants