Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: netrw directories do not have colours #219

Closed
mirandaio opened this issue Jan 26, 2024 · 1 comment
Closed

bug: netrw directories do not have colours #219

mirandaio opened this issue Jan 26, 2024 · 1 comment
Labels

Comments

@mirandaio
Copy link

Neovim version (nvim -v)

0.9.2

Terminal / multiplexer

iTerm2

Describe the bug

rose-pine commit 2a4aad8 does not colour directories in netrw:

Screenshot 2024-01-26 at 08 11 05

while commit e29002c (the last one I had before I updated rose-pine) did:

Screenshot 2024-01-25 at 23 11 56

Could we colour directories in netrw like it was before? It's easier to distinguish directories from files if they are coloured differently.

Thanks!

Repro

vim.o.packpath = "/tmp/nvim/site"

local plugins = {
  rose_pine = "https://github.com/rose-pine/neovim",
}

for name, url in pairs(plugins) do
  local install_path = "/tmp/nvim/site/pack/test/start/" .. name
  if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system({ "git", "clone", "--depth=1", url, install_path })
  end
end

require("rose-pine").setup({})

vim.cmd("colorscheme rose-pine")
@mirandaio mirandaio added the bug label Jan 26, 2024
@mvllow
Copy link
Member

mvllow commented Jan 26, 2024

That's fair, the bold varies quite heavily depending on font/weights. It is coloured, however, if you set styles.bold = false but we probably should always colour them.

You could add this to your config until a change is pushed:

{
  highlight_groups = {
    Directory = {fg = "foam"}
  }
}

mvllow added a commit that referenced this issue Jan 26, 2024
mvllow added a commit that referenced this issue Jan 26, 2024
* feat: add WinBar and WinBarNC

* feat: add new treesitter highlight groups

* perf: parse necessary values upfront

This commit no longer parses each highlight group, but rather user
config values only.

* fix: titles are no longer dynamically coloured

Closes #216 #218 #219
@mvllow mvllow closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants