Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various bug-fixes #270

Merged
merged 20 commits into from
Jan 14, 2025
Merged

various bug-fixes #270

merged 20 commits into from
Jan 14, 2025

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Nov 20, 2024

Changes:

  • Fix lake behaviour
  • Optimise chunked calculations when nothing is in ROI
  • River mouth support for points not contours -
  • Fix gaps in patch (coarse DEM) interpolation due to unintended call to reindex

Not included:

  • Rivers accidental upstream -
  • Rivers fans crossed - 15059243, 11016624
  • Rivers - non land intersect option for fans
  • Turn off rivers geometry errors ignore

Check list:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson rosepearson linked an issue Nov 20, 2024 that may be closed by this pull request
@rosepearson
Copy link
Owner Author

Changes:

  • Fix lake behaviour
  • Optimise chunked calculations when noting is in ROI - replace dask.empty with dask.full(shape, numpy.nan)
  • Rivers accidental upstream -
  • Rivers fans crossed - 15059243, 11016624
  • River mouth support for points not contours -
  • Rivers - non land intersect option for fans

Check list:

  • Make code change

  • Update tests

    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions

  • Update documentation

    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson
Copy link
Owner Author

note working through uncommitted regression. Note here the failing tests:
image

@rosepearson rosepearson added this to the 1.1.25 milestone Jan 14, 2025
@rosepearson rosepearson merged commit 12c8932 into main Jan 14, 2025
2 of 3 checks passed
@rosepearson rosepearson deleted the 269-bugfixes-various branch January 14, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bugfixes various
1 participant