Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cover fake set position #224

Closed
wants to merge 5 commits into from

Conversation

calielc
Copy link

@calielc calielc commented Dec 7, 2020

Changed the behavior of the FakeMode:

  1. it starts with Unknow current_position
  2. if the user moves up/down its wont change the current_position (it remaing unknow)
  3. to the current_position became valid, needs:
  • close by SpanTime (when this happen we know for sure that the position is 0)
  • open by SpanTime (when this happen we know for sure that the position is 100)
  • setPosition, the first time the cover will be fully close and then move to the desired position

@postlund postlund requested a review from rospogrigio December 17, 2020 18:40
@calielc
Copy link
Author

calielc commented Dec 19, 2020

Hi guys, what do you think about this implementation?
Can i improve it in some aspect?

@rospogrigio
Copy link
Owner

Sorry @calielc , I just took a look at this and I'm afraid that PR #213 is even improving this implementation, can you please test it and report your feedback? I would close this PR if you agree so. Let me know, thanks

@rospogrigio
Copy link
Owner

Closing because being fulfilled in #213 .

SKULSHADY pushed a commit to SKULSHADY/localtuya that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants