-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localtuya 4.0 #829
Localtuya 4.0 #829
Conversation
40c6b95
to
ef50285
Compare
ef50285
to
6be13c5
Compare
…assistant into localtuya_4.0
Updated round of testing (WIP/will keep editing comments here)... Version: 2022.5.5 Merged to https://github.com/CloCkWeRX/localtuya-experimental Previous errors - largely gone. Config entry has already been setup!I don't know this is related to the changes in this PR, or if I simply have two devices that look very similar that trigger this. Maybe a variant of what #100 addressed?
Template sensorsI think this is probably me with outdated configuration, rather than specific changes here.
LabelsNow showing up :) No cloud fallback behaviourCan't really test as I can't remove details. |
Alright, seems good to go IMO on both this month and last month's HA install. @rospogrigio merge away! |
Not yet, I realized that you can't actually add the Integration without configuring the cloud credentials, I am adding an option for this, then I think it's merging time. Thank you for the precious review! |
09bb09c
to
3796374
Compare
OK @CloCkWeRX I think I'm ready for release, can you please do some more checks and approve the review? I just added a button to choose not to setup the Cloud API account. Thank you! |
3796374
to
d1a0241
Compare
@CloCkWeRX can you please review the new commits and approve it when you find the time? I will then release the new code. |
LGTM - I can't re-add an approving review/I'm not core so it doesn't pass the "At least 1 approving review is required by reviewers with write access." check, but merge away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice! When can we expect a release? |
Just did it, check it and enjoy! 😉 |
Works flawlessly for me :-) thank you so much!!! |
Major change in Localtuya. Here's what's new: