Added support for multiple gaps operation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @artemk for the pull request! Can you think of a nice way to do this without monkey-patching Array? Like . . . Timeframe.collection(timeframe1, timeframe2).gaps_left_by(timeframe3, timeframe4)or something? |
|
of course i can, but this is more convenient way. Also it not monkey patching Array, but adding new method to open class. |
|
anything new on this? |
|
Haven't had time for the multiyear revamp yet, sadly. Will do ASAP. On this pull request, I'm still uncomfortable with a mandatory core extension to Array. How about you make it optional? You can do this by just removing this line. Timeframe users who want this (fairly obscure, I think) additional functionality would just That work for you? |
Add skip_year_boundary_crossing_check option to #crop
|
Thanks again @artemk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this commit you can use gap operation on multiple timeframes.