Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Iterator instead of Iterable types #77

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: use Iterator instead of Iterable types #77

merged 1 commit into from
Aug 9, 2024

Conversation

uhlikfil
Copy link
Contributor

@uhlikfil uhlikfil commented Aug 9, 2024

Iterator is a better type for the method return value, since it correctly type checks the use of next(). Iterable interface doesn't.

fix: use Iterator instead of Iterable types
77edb52 
Iterator is a better type for the method return value,
since it correctly type checks the use of `next()`.
Iterable interface doesn't.
asgeirrr
asgeirrr approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@asgeirrr asgeirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'm always torn whether to use Iterable or Iterator but in the return types it should definitely be the more specific type 👍

@asgeirrr asgeirrr merged commit ef1b4e2 into rossumai:main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgeirrr asgeirrr asgeirrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhlikfil @asgeirrr