New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Corrected @param in comment block #35

Open

rostyslav-hymon wants to merge 1 commit into 2.3-develop from 2.3-develop-PR-port-14892

Owner

rostyslav-hymon commented Apr 30, 2018

Original Pull Request

magento#14892
The parameters mentioned in the comment block above constructor are not identical with the parameters passed in the constructor.

Description

Replaced \Magento\Backend\Helper\Data parameter with \Magento\Backend\Model\UrlInterface to make them identical with contructor.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)


          Corrected params in comment block

bfeaf52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet