Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Add missing implementation for applySortOrder() #9

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

rostyslav-hymon
Copy link
Owner

Original Pull Request

magento#13641

Description

The totals block for the frontend order view has a method applySortOrder to manipulate ordering of already added totals. Alas this method was never implemented.

It is also currently not used in the core, so this PR is only a partial solution to the issue linked below. But having it implemented is useful for third party extensions as a sensible way to reorder the totals.

Fixed Issues (if relevant)

  1. Totals sort order is not respected in customer account order view magento/magento2#13631:Totals sort order is not respected in customer account order view (not fixed but related)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@rostyslav-hymon rostyslav-hymon merged commit a7ff305 into 2.3-develop Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants