Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: /contact page #428

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: /contact page #428

wants to merge 12 commits into from

Conversation

rotimi-best
Copy link
Owner

What does this PR do?

Adds a /contact page to landing page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 10, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@vercel Vercel
Copy link

vercel bot commented Aug 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cio-com ❌ Failed (Inspect) Aug 22, 2024 8:48am
cio-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:48am

@rotimi-best rotimi-best marked this pull request as draft August 10, 2024 07:49
rotimi-best
rotimi-best commented Aug 17, 2024
View reviewed changes
apps/classroomio-com/src/lib/types.ts Outdated
Comment on lines 24 to 27
bug = 'bug',
help = 'help',
feature = 'feature',
feedback = 'feedback'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chifez Please make them all capital letter

apps/classroomio-com/src/routes/contact/+page.svelte Outdated
import Forms from '$lib/ContactUs/Forms/Index.svelte';
import { FORM_TYPE } from '$lib/types';

let currentForm: keyof typeof FORM_TYPE;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstact keyof typeof FORM_TYPE to its own type cause I see you are using it more than once

type FORM_TYPE_KEY = keyof typeof FORM_TYPE;

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chifez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rotimi-best @Chifez