feat: Update Landing page background Image #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
rotimi-best
requested changes
Sep 16, 2024
Comment on lines
-589
to
-597
| <style> | ||
| .banner { | ||
| background: url('/images/org-landingpage-banner.jpeg') no-repeat center center fixed; | ||
| -webkit-background-size: cover; | ||
| -moz-background-size: cover; | ||
| -o-background-size: cover; | ||
| background-size: cover; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
@Chifez Why did you remove the default background?
Did you think about what happens for users that don't have this setting enabled?
You've just broken the UI for previous customers while adding a new functionality for new customers.
| @@ -81,6 +85,11 @@ export const landingPageSettings: Writable<OrgLandingPageJson> = writable({ | |||
| type: 'video', | |||
| show: true | |||
| }, | |||
| background: { | |||
| image: | |||
| 'https://tapaozmyjsuykgerrfkt.supabase.co/storage/v1/object/public/avatars/landingpage/riverside.jpeg', | |||
There was a problem hiding this comment.
Can you use the image we used for the previous background?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the user to do the following
Fixes #467
bandicam.2024-09-09.15-19-24-227.mp4
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated