add collections' main asset #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabirgb
reviewed
Dec 5, 2024
Comment on lines
3
to
4
| UPDATE asset_collections SET main_asset='eip155:1/erc20:0xB6eD7644C69416d67B522e20bC294A9a9B405B31' WHERE id=0; | ||
| INSERT INTO asset_collections(id, name, symbol) VALUES (0, '0xBitcoin', '0xBTC'); |
There was a problem hiding this comment.
shouldn't the insert have the main asset also in the query?
There was a problem hiding this comment.
that'd require the refactor of the assets updater.
normally, the UPDATE statements are sufficient since the data already exists in the database but the INSERTS are needed since the tests expect such format.
prettyirrelevant
force-pushed
the
collection-main-asset
branch
from
1ec8341 to
a43a3c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.