Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accounting rules #129

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix accounting rules #129

merged 1 commit into from
Sep 18, 2024

Conversation

yabirgb
Copy link
Member

@yabirgb yabirgb commented Sep 18, 2024

We made a mistake in v3 and the first rule had in the body

            "event_type": "fail",
            "event_subtype": "fee",
            "event_type": "spend",
            "event_subtype": "payment",

since spend/payment was the last one the rule for fail/fee wasn't processed correctly. This PR moves it to v4 and removes it from v3 so users can get it correctly. ALso solves a warning about duplicate entries

LefterisJP
LefterisJP approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LefterisJP LefterisJP merged commit aee112b into rotki:develop Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LefterisJP LefterisJP LefterisJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yabirgb @LefterisJP