Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revamp profile pages #145

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: revamp profile pages #145

merged 1 commit into from
Sep 27, 2023

Conversation

lukicenturi
Copy link
Contributor

No description provided.

@lukicenturi lukicenturi force-pushed the 138-new-profile-page branch 5 times, most recently from e1da960 to 4175875 Compare September 5, 2023 09:49
@lukicenturi lukicenturi force-pushed the 138-new-profile-page branch 4 times, most recently from e10917a to 534be62 Compare September 16, 2023 18:38
@lukicenturi lukicenturi mentioned this pull request Sep 16, 2023
Merged
5 tasks
@lukicenturi
Copy link
Contributor Author

lukicenturi commented Sep 16, 2023 •
edited
Loading

The features from this PR is done, but unfortunately the typecheck is not working. This is the PR to fix it rotki/ui-library#115, but it still need one more thing to do (Check the PR).

lukicenturi
lukicenturi commented Sep 16, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@tewshi tewshi marked this pull request as ready for review September 25, 2023 11:32
@tewshi tewshi requested a review from a team as a code owner September 25, 2023 11:32
tewshi
tewshi approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@tewshi tewshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kelsos kelsos self-assigned this Sep 25, 2023
kelsos
kelsos reviewed Sep 26, 2023
View reviewed changes
components/account/home/PremiumPlaceholder.vue Outdated
<NuxtLink :class="css.link" to="/checkout/plan">
premium subscription plan.
</NuxtLink>
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if we skip the extra div here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kelsos
kelsos reviewed Sep 26, 2023
View reviewed changes
components/account/home/ApiKeys.vue Outdated
:class="css.input"
<div class="grid md:grid-cols-2 gap-4">
<RuiRevealableTextField
id="username"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to change the id here and below :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kelsos
Copy link
Member

kelsos commented Sep 26, 2023

So I think we should not show this this low, and second it should auto-dismiss after some time.

image

@kelsos
Copy link
Member

kelsos commented Sep 26, 2023

Another thing is that there is no visual feedback at all on regenerate of API keys.

The first time it is obvious that something happened but after that there is no indication.

@kelsos
Copy link
Member

kelsos commented Sep 26, 2023

Another thing that seems to be broken is the redirect link to home after buying a subscription.
it points to /home which gives a 404.

@lukicenturi @tewshi @kelsos
feat: revamp user home page
f8ad2d3 
Co-authored-by: Joseph Ojoko <entewshi@gmail.com>
kelsos
kelsos approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kelsos kelsos merged commit f8ad2d3 into rotki:main Sep 27, 2023
6 checks passed
@kelsos kelsos mentioned this pull request Sep 27, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewshi tewshi tewshi approved these changes

@kelsos kelsos kelsos approved these changes

Assignees

@kelsos kelsos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukicenturi @kelsos @tewshi