Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init dependencies #6

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

lukicenturi
Copy link
Contributor

Closes #2

@lukicenturi lukicenturi requested a review from a team as a code owner March 28, 2023 07:23
@lukicenturi lukicenturi force-pushed the init-dependencies branch 8 times, most recently from 73d8f61 to aa1ef1c Compare March 28, 2023 07:26
@lukicenturi
Copy link
Contributor Author

There is still some problem with the vue-demi, I tried it in the project with vue-3 installed, but it's not working.

@lukicenturi
Copy link
Contributor Author

lukicenturi commented Mar 28, 2023

There is still some problem with the vue-demi, I tried it in the project with vue-3 installed, but it's not working.

I think I know why, vue-demi can't work with component written in SFC
vueuse/vue-demi#139

All the examples given in the vue-demi have been in .ts file

New update: I'm trying this approach vueuse/vue-demi#139 (comment)

.storybook/main.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@lukicenturi lukicenturi force-pushed the init-dependencies branch 2 times, most recently from 745f5c4 to 8ef6c33 Compare March 28, 2023 12:05
@kelsos
Copy link
Member

kelsos commented Mar 28, 2023

There is still some problem with the vue-demi, I tried it in the project with vue-3 installed, but it's not working.

I think I know why, vue-demi can't work with component written in SFC vueuse/vue-demi#139

All the examples given in the vue-demi have been in .ts file

New update: I'm trying this approach vueuse/vue-demi#139 (comment)

Good let me know when to check again @lukicenturi thanks :)

@lukicenturi lukicenturi force-pushed the init-dependencies branch 8 times, most recently from 9dd5d9d to 45bd891 Compare March 28, 2023 14:58
@lukicenturi
Copy link
Contributor Author

There is still some problem with the vue-demi, I tried it in the project with vue-3 installed, but it's not working.

I think I know why, vue-demi can't work with component written in SFC vueuse/vue-demi#139
All the examples given in the vue-demi have been in .ts file
New update: I'm trying this approach vueuse/vue-demi#139 (comment)

Good let me know when to check again @lukicenturi thanks :)

I think the vue-demi works now.

@lukicenturi lukicenturi force-pushed the init-dependencies branch 3 times, most recently from 927cd9f to 62a9f11 Compare March 28, 2023 15:04
package.json Outdated Show resolved Hide resolved
@rotki rotki deleted a comment from lukicenturi Mar 28, 2023
scripts/dist-select.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@kelsos
Copy link
Member

kelsos commented Mar 28, 2023

Btw pnpm run storybook is the only thing I need after pnpm install or do I need something else too?

image

@lukicenturi lukicenturi force-pushed the init-dependencies branch 2 times, most recently from 9beb047 to 67d377a Compare March 28, 2023 17:38
@lukicenturi
Copy link
Contributor Author

lukicenturi commented Mar 28, 2023

Btw pnpm run storybook is the only thing I need after pnpm install or do I need something else too?

image

hmm yeah I tried only pnpm install and I can run the storybook.
the openBlock is thing from vue3, but the storybook should run with vue2.7🧐

@kelsos
Copy link
Member

kelsos commented Mar 28, 2023

Btw pnpm run storybook is the only thing I need after pnpm install or do I need something else too?
image

hmm yeah I tried only pnpm install and I can run the storybook. the openBlock is thing from vue3, but the storybook should run with vue2.7🧐

Can you try on a fresh checkout? too (remove node-modules and try to pnpm install only with the lock file)

@lukicenturi lukicenturi force-pushed the init-dependencies branch 2 times, most recently from d05417d to 5e44f46 Compare March 29, 2023 09:06
@lukicenturi
Copy link
Contributor Author

Btw pnpm run storybook is the only thing I need after pnpm install or do I need something else too?
image

hmm yeah I tried only pnpm install and I can run the storybook. the openBlock is thing from vue3, but the storybook should run with vue2.7🧐

Can you try on a fresh checkout? too (remove node-modules and try to pnpm install only with the lock file)

You can try again. I added the script to switch to vue2.7 automatically when we run the storybook.

@kelsos kelsos marked this pull request as ready for review March 29, 2023 10:39
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I will create a basic CI configuration and after that we can start implementing stuff

@kelsos kelsos merged commit 7226c84 into rotki:main Mar 29, 2023
@lukicenturi lukicenturi deleted the init-dependencies branch April 5, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap the base for the component library
2 participants