Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test scope to outer dependencies in the pom of extended-tests #34

Closed
pgrt opened this issue Jan 30, 2022 · 1 comment
Closed

Adding test scope to outer dependencies in the pom of extended-tests #34

pgrt opened this issue Jan 30, 2022 · 1 comment

Comments

@pgrt
Copy link

pgrt commented Jan 30, 2022

Hi,

Because the outer dependencies of extended-tests are only used in the tests, I believe they can be safely marked with
test
like in the attached patch.

missing_test_scope.txt

Best,
Pierre
rototor added a commit that referenced this issue Jan 31, 2022
@rototor
#34 Those dependencies are only needed for tests.
5c29a90
@rototor
Copy link
Owner

rototor commented Jan 31, 2022

Thanks for the report, I've applied your patch. Regarding the extended-tests package I post some comments on #33.

@rototor rototor closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rototor @pgrt