Added support for Apache PDFBox TilingPaint. #25
Conversation
There was a problem hiding this comment.
Thanks for the PullRequest.
Please provide a sample PDF, that triggers this code path. And a line in PdfRerenderTest.rerenderPDF() to rerender this sample. I will then merge this and try to get a patch upstream to PDFBox to correctly access the TilingPaint internals.
| catch (NoSuchFieldException ignored) | ||
| { | ||
| } | ||
| throw new NullPointerException("Field " + fieldName + " not found!"); |
There was a problem hiding this comment.
Not rethrowing the underlying NoSuchFieldException seems strange. The method getPropertyValue() you likely copied here did loop, and ignored that error because of that. When accessing a private field you in theory also need to loop.
There was a problem hiding this comment.
You're right, it should throw and I've changed it back to use a loop as you suggest. The theory was that a private field is only accessible from the class that contains it, but we've already broken encapsulation.
| private void applyTilingPaint(Paint paint, PaintApplierState state) throws IOException | ||
| { | ||
| TexturePaint texturePaint = getPrivateFieldValue(paint, "paint"); | ||
| applyTexturePaint(texturePaint, state); |
There was a problem hiding this comment.
Casting this to TexturePaint is likely calling for trouble. Why did you not simply call applyPaint() here with this paint?
Also you ignore the patternMatrix.
There was a problem hiding this comment.
Good point - that is a better way to handle it. Also added some exception handling to catch any issues with private field access.
I think the patternMatrix should be accounted for already. In the TilingPaint class, the TexturePaint field is initialised from getImage(...) which applies the anchorRect and patternMatrix. The source and converted PDFs look the same.
| try | ||
| { | ||
| Field f = c.getDeclaredField(fieldName); | ||
| f.setAccessible(true); |
There was a problem hiding this comment.
This wont work in JDK9+ :( There are hacks (Unsafe&Friends) to workaround that, but I am not sure that I want to import them here.
There was a problem hiding this comment.
Hopefully we can get the patch for PDFBox to make this unnecessary.
Unfortunately, we've only seen this case once so far, and the source is proprietary, so I'm not able to share it. I'm also not sure how to generate a PDF with this type of content at the moment, but will try to get a sample if possible. |
|
Ok, I'll merge that now and
|
found that the matrix has to be applied somehow.
|
I found a test case, as I already use the TilingPattern for some special cases when I need some pattern/gradient as a stroke fill. E.g. when using to draw a stroke. And in my test case the matrix seems to be needed. Thats something I still need to fix. |
We encountered an issue where a TilingPaint object may be passed to the applyPaint method of PdfBoxGraphics2DPaintApplier, but is not currently handled.
Our solution reads the private TexturePaint field of the TilingPaint object and passes it to the existing applyTexturePaint method.