Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -h/--dereference to tar in release action #176

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

WardBrian
Copy link
Collaborator

A user who was using Windows without administrative permissions reported to me that BridgeStan was failing to install the C++ sources due to a permissions error.

Some investigating showed that this was due to the symlink in rust/src, since symlinks are always permission 0777. After some digging, I found that GNU tar supports replacing symlinks with their targets by passing -h/--dereference, and in fact recommends doing this:

So, for portable archives, do not archive symbolic links as such, and use --dereference (-h): many systems do not support symbolic links, and moreover, your distribution might be unusable if it contains unresolved symbolic links.

Unfortunately this will only begin to take effect in the next release, and we're unable to update previous releases due to the Julia artifact containing a hash of those tarfiles.

@WardBrian WardBrian added the github_actions Pull requests that update GitHub Actions code label Oct 2, 2023
@WardBrian
Copy link
Collaborator Author

@roualdes IMO it might be worth releasing a 2.2.1 after this with the only change being the fixed tar

Copy link
Owner

@roualdes roualdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Agreed, let's release 2.2.1 after this.

@WardBrian WardBrian merged commit 0db311e into main Oct 2, 2023
@WardBrian WardBrian deleted the fix/python-tar-permissions-issues branch October 2, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants