New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. cleanups #191

Merged

WardBrian merged 2 commits into main from python/cleanups

Dec 5, 2023

Collaborator

WardBrian commented Dec 5, 2023

While looking into #190, I found a few small improvements:

Using ctypes.byref is cheaper than actually constructing a ctypes.pointer
Some missing return type annotations
A few places where we said 'Bridgestan' instead of 'BridgeStan'

WardBrian added 2 commits

December 5, 2023 09:27


          Use byref where applicable

eb9ae5b


          Properly capitalize BridgeStan

e51afe6

WardBrian added the python label

roualdes approved these changes

View reviewed changes

Owner

roualdes left a comment

Great find. Thanks.

Here's a quick reference to that claim, for whatever it's worth. Python ctypes.byref() doc.

WardBrian merged commit d37a860 into main

19 checks passed

WardBrian deleted the python/cleanups branch

December 5, 2023 21:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels