Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Julia TBB detection to instantiation time #213

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

WardBrian
Copy link
Collaborator

Unlike Python or R, Julia was setting up the Windows PATH at startup rather than at runtime. Among other things, this meant that calls to set_bridgestan_path couldn't influence this, since by the time that function was available, it was already too late.

This is in part thanks to a forum report: https://discourse.mc-stan.org/t/various-compilation-problems-with-various-interfaces/34155/5

Copy link
Owner

@roualdes roualdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for looking into this Discourse report.

@WardBrian WardBrian merged commit c789e48 into main Feb 20, 2024
19 checks passed
@WardBrian WardBrian deleted the runtime-tbb-setup branch February 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants